runat-1128988: More robust error reporting

If a promise rejected with null/undefined, then we previously made a bad thing worse. Now we protect ourselves. Signed-off-by: Joe Walker <[email protected]>
joewalker · Feb 5, 2015 · 05b78be · 05b78be · bgrins · Feb 24, 2015
1 parent c8ccc9f
commit 05b78be
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/lib/gcli/testharness/examiner.js b/lib/gcli/testharness/examiner.js
@@ -379,6 +379,14 @@ Test.prototype.run = function(options) {
  * Object.toString could be a lot better
  */
 function toString(err) {
+  if (err === null) {
+    return 'null';
+  }
+
+  if (err === undefined) {
+    return 'undefined';
+  }
+
   // Convert err to a string
   if (typeof err === 'string') {
     return err;