Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix #13 #15

Merged
merged 2 commits into from
Jun 22, 2023
Merged

bugfix #13 #15

merged 2 commits into from
Jun 22, 2023

Conversation

dvhh
Copy link
Collaborator

@dvhh dvhh commented Aug 30, 2021

No description provided.

@God-damnit-all
Copy link

@joernhees Would you please merge this and #14?

@God-damnit-all
Copy link

@dvhh Actually, it looks like there's a mistake with this PR. You're calling os.path.exists, but because Compressor.py uses from os.path import basename, join, dirname, exists, the line in this PR should just be if not exists(filename):

@dvhh
Copy link
Collaborator Author

dvhh commented May 19, 2023

Thanks for the feedback @ImportTaste, will correct

@dvhh dvhh merged commit 55a1cb7 into master Jun 22, 2023
@dvhh dvhh deleted the file_check branch June 22, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvhh @God-damnit-all