chore: lints

joerdav · Nov 30, 2023 · e7cbab8 · e7cbab8
1 parent 84c4ec2
commit e7cbab8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/parser/parser.go b/parser/parser.go
@@ -14,6 +14,7 @@ import (
 var ErrNoTasksHeading = errors.New("no xc block found")
 
 const trimValues = "_*` "
+const codeBlockStarter = "```"
 
 type parser struct {
 	scanner               *bufio.Scanner
@@ -187,15 +188,15 @@ func (p *parser) parseAttribute() (bool, error) {
 
 func (p *parser) parseCodeBlock() error {
 	t := p.currentLine
-	if len(t) < 3 || t[:3] != "```" {
+	if len(t) < 3 || t[:3] != codeBlockStarter {
 		return nil
 	}
 	if len(p.currTask.Script) > 0 {
 		return fmt.Errorf("command block already exists for task %s", p.currTask.Name)
 	}
 	var ended bool
 	for p.scan() {
-		if len(p.currentLine) >= 3 && p.currentLine[:3] == "```" {
+		if len(p.currentLine) >= 3 && p.currentLine[:3] == codeBlockStarter {
 			ended = true
 			break
 		}

diff --git a/parser/parser_test.go b/parser/parser_test.go
@@ -152,9 +152,9 @@ func TestHeadingCaseInsensitive(t *testing.T) {
 		p, _ := NewParser(strings.NewReader(fmt.Sprintf(`
 # %s
 ## a task
-`+"```"+`
+`+codeBlockStarter+`
 some code
-`+"```"+`
+`+codeBlockStarter+`
 `, tt.mdHeading)), tt.parserHeading)
 		_, err := p.parseTask()
 		if err != nil {
@@ -171,7 +171,7 @@ func TestUnTerminatedCodeBlock(t *testing.T) {
 	p, _ := NewParser(strings.NewReader(`
 # Tasks
 ## a task
-`+"```"+`
+`+codeBlockStarter+`
 some code
 `), "tasks")
 	_, err := p.parseTask()
@@ -357,10 +357,10 @@ Requires: list, list2
 ` + "Env: `somevar=val`" + `
 Inputs: FOO, BAR
 
-` + "```" + `
+` + codeBlockStarter + `
 echo "Hello, world!"
 echo "Hello, world2!"
-` + "```")
+` + codeBlockStarter)
 	}
 	file := buf.String()
 	for i := 0; i < b.N; i++ {