Add support for including JsonTypeInfo Annotation #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation onto all generated classes as described in joelittlejohn#958
| @@ -752,6 +760,10 @@ | |||
| */ | |||
| private boolean useInnerClassBuilders = false; | |||
|
|
|||
| public Jsonschema2PojoMojo() | |||
There was a problem hiding this comment.
I don't think we need this constructor.
jsonschema2pojo-core/src/main/java/org/jsonschema2pojo/rules/ObjectRule.java
Outdated
Show resolved
Hide resolved
jsonschema2pojo-core/src/main/java/org/jsonschema2pojo/rules/ObjectRule.java
Outdated
Show resolved
Hide resolved
…rializationClassProperty.
…y not always implement through annotations.
…to annotator implementations.
…to annotator implementations. Updated composite annotator and tests instances.
…rializationClassProperty in ant plugin.
|
I think I am done with all my changes. I additionally made some additional changes but nothing big. |
|
@joelittlejohn I believe I have addressed all your review comments. |
|
@ddcruver Amazing. Thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for including the Jackson 1 & 2 JsonTypeInfo Annotation to generated classes.