Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of targetVersion for Android gradle builds #1487

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

joelittlejohn
Copy link
Owner

@joelittlejohn joelittlejohn commented Feb 18, 2023

This fixes the broken targetVersion detection for Gradle Android builds, and also updates the Android Sample GitHub action so that it actually runs against the HEAD code (rather than the latest release).

@joelittlejohn joelittlejohn added this to the 1.2.1 milestone Feb 18, 2023
@joelittlejohn joelittlejohn force-pushed the fix-android-target-version-detect branch from 50f2a29 to 1a27698 Compare February 18, 2023 11:33
@joelittlejohn joelittlejohn force-pushed the fix-android-target-version-detect branch from 1a27698 to 0a57923 Compare February 18, 2023 11:40
Copy link
Collaborator

@unkish unkish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked like a charm locally 👍

@joelittlejohn joelittlejohn merged commit 1afa7c8 into master Feb 18, 2023
@joelittlejohn joelittlejohn deleted the fix-android-target-version-detect branch February 18, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants