Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let AnnotationHelper respect targetVersion #1474

Closed
wants to merge 1 commit into from

Conversation

XN137
Copy link

@XN137 XN137 commented Feb 2, 2023

this should avoid the problem of using the wrong annotation when building on jdk 11 but targeting java 8

@XN137 XN137 force-pushed the java9-generated-annotation branch from 61a5047 to 09b26ca Compare February 2, 2023 11:08
@XN137 XN137 marked this pull request as ready for review February 2, 2023 11:08
@XN137 XN137 force-pushed the java9-generated-annotation branch 2 times, most recently from 59bad72 to a38d7e7 Compare February 2, 2023 13:57
this should avoid the problem of using the wrong annotation when
building on jdk 11 but targetting java 8
@joelittlejohn
Copy link
Owner

Superseded by #1482.

@XN137 XN137 deleted the java9-generated-annotation branch February 14, 2023 23:11
joelittlejohn added a commit that referenced this pull request Feb 14, 2023
joelittlejohn added a commit that referenced this pull request Feb 15, 2023
joelittlejohn added a commit that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants