Add @Generated annotation to classes and includeGeneratedAnnotation config option

[cyclotomic18]

Restores the feature which added @javax.annotation.Generated annotation to generated code. In addition, the feature becomes conditional on a boolean configuration property "markGenerated" (as in JAXB. openapi ecc...), defaulted to false.
Addresses #1162 and related, without falling back to #577.

[cyclotomic18]

Imo, this feature is of extreme importance in a code-genereation tool like this, for the reason i mentioned in #835 (comment). Thus, i kindly ask for an asap minor including this feature, if and once it's approved and all good.

[joelittlejohn]

I'm actually tempted to turn this back on by default, with logic like:

• add javax.annotation.Generated if it is available
• if not, add javax.annotation.processing.Generated if it is available

This doesn't specifically use the target 'source compliance' version but it's a good compromise IMO. We are already moving to 1.1.0 for other reasons (and the versioning scheme in this project means that changes like this are expected).

[joelittlejohn]

Out of interest, are you using Java 8?

[cyclotomic18]

No, I'm using java 11, but Spring Boot packs jackarta.annotation-api (which contains javax.annotation.Generated) so I have no issue about that.
However, I mostly agree with resolving the type of Generated the way you exposed...I just wanted to address the main issue, that is the current absence of a primary feature.
I'm not sure about turning it on by default, do you mean with no prop at all or by defaulting the prop to true? For sure I wouldn't go with the first solution; the second one is pretty much just a 50/50 choice, I think everyone is good as long as the feature is present in some way...maybe it's better to stay as clean as possible with a default/minimal configuration, though? Idk.

[joelittlejohn]

Yeah, I think we could keep the flag and have it true by default. This means in the CLI using something like --omit-generated-annotation as the flag (the presence of the flag sets it to false).

I realise you have matched jaxb, but in this project we usually name flags like this includeXXX (these control what is added to the ouput), so I'd prefer includeGeneratedAnnotation (default true) for all the other plugins.

Also, the value of the Generated annotation should be "jsonschema2pojo". The name of the generator.

[cyclotomic18]

I made the changes you mentioned in your last comment

[joelittlejohn]

Awesome. Could you combine your commits? I'll make some further changes to detect which generated annotation is available before 1.1.0 is released.

[cyclotomic18]

I rebased with master and force-pushed.
When's 1.1.0 going to be released approximately?

[joelittlejohn]

@cyclotomic18 Soon I'd say. I expect it will be this week.

[cyclotomic18]

Awesome, thank you for the support!

[joelittlejohn]

@cyclotomic18 1.1.0 is released now 👍

[cyclotomic18]

Ye, already included in my project, all good to go now. Thanks!