-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled delete and up/down arrow keys #54
Merged
joelekstrom
merged 5 commits into
joelekstrom:master
from
kalkwarf:additional-keyhandlers
Dec 14, 2021
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ce37f66
Enabled delete and up/down arrow keys
kalkwarf 89fe27c
Align content so it doesn't shift while switching tabs
kalkwarf 860bc87
Preferences UI for arrow navigation
kalkwarf 1fa55bc
Obey the UserDefault for key navigation
kalkwarf ccfd1c0
Sorted imports
kalkwarf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,13 @@ | ||
@import Carbon.HIToolbox; | ||
#import "AppDelegate.h" | ||
#import "UnreadCountObserver.h" | ||
#import "NotificationCenter.h" | ||
#import "WebViewController.h" | ||
#import "KVOBlockObserver.h" | ||
#import "NotificationCenter.h" | ||
#import "PrintManager.h" | ||
#import "UnreadCountObserver.h" | ||
#import "UserDefaultsKeys.h" | ||
#import "UserDefaultsKeys.h" | ||
#import "VersionChecker.h" | ||
#import "PrintManager.h" | ||
#import "WebViewController.h" | ||
|
||
@interface AppDelegate () <VersionCheckerDelegate, NotificationCenterDelegate> | ||
|
||
|
@@ -56,6 +58,7 @@ - (UnreadCountObserver *)unreadCountObserver { | |
|
||
- (void)applicationDidBecomeActive:(NSNotification *)notification { | ||
[NSUserDefaults.standardUserDefaults registerDefaults:@{ | ||
ArrowNavigatesMessageListKey: @NO, | ||
AutomaticUpdateChecksKey: @YES, | ||
ShouldShowUnreadMailIndicatorKey: @YES, | ||
ShouldShowUnreadMailInDockKey: @YES, | ||
|
@@ -189,4 +192,29 @@ - (void)notificationCenter:(NotificationCenter *)center notificationClickedWithI | |
[self.mainWebViewController handleNotificationClickWithIdentifier:identifier]; | ||
} | ||
|
||
#pragma mark - Raw key handler | ||
- (BOOL)handleKey:(NSEvent *)event { | ||
switch (event.keyCode) { | ||
case kVK_UpArrow: | ||
if ([NSUserDefaults.standardUserDefaults boolForKey:ArrowNavigatesMessageListKey]) { | ||
return [self.mainWebViewController nextMessage]; | ||
} else { | ||
return NO; | ||
} | ||
|
||
case kVK_DownArrow: | ||
if ([NSUserDefaults.standardUserDefaults boolForKey:ArrowNavigatesMessageListKey]) { | ||
return [self.mainWebViewController previousMessage]; | ||
} else { | ||
return NO; | ||
} | ||
|
||
case kVK_Delete: | ||
return [self.mainWebViewController deleteMessage]; | ||
|
||
default: | ||
return NO; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Next step is here in the delegate. If it's not one of the three raw keys, tell the application controller we didn't want the event. |
||
} | ||
} | ||
|
||
@end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here (and line 206) we look at the new setting, and either toss the event (letting the default behavior occur) or we attempt to have the
mainWebViewController
deal with it.