Code tidy up for you #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added sln file for convenience. Removed irrelevant cywin path from ignore file. Added nuget packages/ to ignore file.
Should be much clearer what calls to this are doing now. :-)
This should improve clarity of what the class is and what it's for.
For extra clarity. I had difficulty telling apart the framework from the organisation classes.
To show that they aren't using anything non-static.
More code doc for PageStructureBuilderModule class.
personal preference
Noticed a difference in the two code paths, need to figure out why they are different and document it.
Doesn't seem to be any good reason for the extra subfolder.
…...) Correction to code doc.
|
I've added a whole load more rework, hopefully it's more self-describing, and usable as a library now. It's now significantly different to your blog post so if you did pull it in, you may want to update it a bit so the names match. Sorry! |
I understand it now, they are both actually PageData objects
I don't yet understand what the purpose of this feature is.
|
There's probably not going to be much more now as I think I understand it enough to make use of it now. I'll let you be the judge of whether what I've done is an improvement or not :-) |
Put the background at the end of the readme. Added a summary line to the readme. Move build dependencies above code usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watcha, cheers for yet another excellent piece of code and very helpful blog post.
I've done some tidying up and documenting of your module's code, and thought you might like it.
There shouldn't be any changes to the functionality in this set of changes.
More to follow!
Tim Abell