Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused client secret #167

Closed
uhthomas opened this issue May 9, 2024 · 1 comment · Fixed by #168
Closed

remove unused client secret #167

uhthomas opened this issue May 9, 2024 · 1 comment · Fixed by #168

Comments

@uhthomas
Copy link
Collaborator

uhthomas commented May 9, 2024

Describe the bug

Per #77, it looks like the operator is creating an unused secret and it should be removed.

To Reproduce

N/A

Expected behavior

The secret should not exist.

Screenshots

N/A

Additional context

N/A
@uhthomas
Copy link
Collaborator Author

uhthomas commented May 9, 2024

I wonder if the operator should also cleanup previously created client secrets? Maybe not worth the hassle?

uhthomas added a commit that referenced this issue May 9, 2024
@uhthomas
chore(pkg/controllers): remove unused secret and no-op byte slice com…
8e37dc7 
…parisons

Fixes: #167
uhthomas added a commit that referenced this issue May 9, 2024
@uhthomas
chore(pkg/controllers): remove unused secret and no-op comparisons
2dacfde 
Fixes: #167
@uhthomas uhthomas mentioned this issue May 9, 2024
Merged
jodevsa pushed a commit that referenced this issue May 11, 2024
@uhthomas
chore(pkg/controllers): remove unused secret and no-op comparisons (#168
a11b890 
)

Fixes: #167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(pkg/controllers): remove unused secret and no-op comparisons jodevsa/wireguard-operator
1 participant
@uhthomas