fix: only add address as loadbalancerIP if svc type is LoadBalancer (#…

…203)
jodevsa · Jul 17, 2024 · 56a609d · 56a609d
1 parent e1e7646
commit 56a609d
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/pkg/controllers/wireguard_controller.go b/pkg/controllers/wireguard_controller.go
@@ -684,8 +684,7 @@ func (r *WireguardReconciler) serviceForWireguard(m *v1alpha1.Wireguard, service
 			Labels:      labels,
 		},
 		Spec: corev1.ServiceSpec{
-			LoadBalancerIP: m.Spec.Address,
-			Selector:       labels,
+			Selector: labels,
 			Ports: []corev1.ServicePort{{
 				Protocol:   corev1.ProtocolUDP,
 				NodePort:   m.Spec.NodePort,
@@ -696,6 +695,10 @@ func (r *WireguardReconciler) serviceForWireguard(m *v1alpha1.Wireguard, service
 		},
 	}
 
+	if svc.Spec.Type == corev1.ServiceTypeLoadBalancer {
+		svc.Spec.LoadBalancerIP = m.Spec.Address
+	}
+
 	if err := ctrl.SetControllerReference(m, svc, r.Scheme); err != nil {
 		return nil, fmt.Errorf("set controller reference: %w", err)
 	}