Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to bikeshed the name! This adds a new key,
gpgWarnOnFailure
, which is scoped toZero
andpublishLocal
. InpublishLocal
it is defaulted totrue
, and everywhere else it defaults tofalse
. A value oftrue
will override the default behavior and allow publication to succeed even if signing fails. A value offalse
corresponds to "fail on failure" and will result in the build halting if signing cannot be completed successfully.Oh I also fixed a previously-undiscovered bug when
gpgWarnOnFailure := true
and signing fails for not-the-first file. Previously, the warning would report that "Artifacts won't be signed", but in fact some of the signatures would have still been published. The behavior is now consistent with the error message: when any files fail to sign, no signatures are published.Also as a bonus, I fixed
gpg
's process output to redirect fully to SBT's logging. This always annoyed me aboutgpg
from within sbt-pgp.Fixes #3