Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on parsing of zero-prefixed RCNs #150

Merged
merged 3 commits into from
Sep 22, 2022

Conversation

jodal
Copy link
Owner

@jodal jodal commented Sep 22, 2022

This PR fixes a crash on parsing of RCNs that are zero-padded to a GTIN-14.

Also, add tests of:

  • German variable measure check digit error
  • German variable measure zeroing

@jodal jodal self-assigned this Sep 22, 2022
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (7dbd304) compared to base (912920f).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 7dbd304 differs from pull request most recent head 29c8426. Consider uploading reports for the commit 29c8426 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #150   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          851       853    +2     
  Branches       127       127           
=========================================
+ Hits           851       853    +2     
Impacted Files Coverage Δ
src/biip/gtin/_rcn.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jodal jodal force-pushed the jodal/fix-zero-padded-rcn-crash branch from 7dbd304 to 29c8426 Compare September 22, 2022 11:33
@jodal jodal merged commit 7e89525 into main Sep 22, 2022
@jodal jodal deleted the jodal/fix-zero-padded-rcn-crash branch September 22, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant