#356 #365
Merged
#356 #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a Markdown file for the cruise FAQ. And, there is now a common method for displaying styled Markdown in a page with the site header. The cruise FAQ, About Twitarr, and Code Of Conduct pages all use this method. We previously had checked in a Markdown version of the CoC, but weren't using it to render the page. Previously, the CoC render parsed the oddly-formatted JSON file; I believe "codeofconduct.json" is no longer used by Swiftarr. Keeping the file in place as it's in /public and clients may still try to access it. However, the JSON file should be considered deprecated and we should try to remove it in the future.
|
Tricordarr grabs the json file directly to render locally. I can process Markdown too, as long as it's consistently at a similar path (which it seems to be). |
cohoe
requested changes
Jan 14, 2025
|
I'm fine with nuking the coc json now |
cohoe
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Markdown file for the cruise FAQ. And, there is now a common method for displaying styled Markdown in a page with the site header. The cruise FAQ, About Twitarr, and Code Of Conduct pages all use this method. We previously had checked in a Markdown version of the CoC, but weren't using it to render the page.
Previously, the CoC render parsed the oddly-formatted JSON file; I believe "codeofconduct.json" is no longer used by Swiftarr. Keeping the file in place as it's in /public and clients may still try to access it. However, the JSON file should be considered deprecated and we should try to remove it in the future.