CPT-127 Make list of attachments accessible again #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When opening the list of attachments, Odoo wants to display the total number of items in the list. This is displayed in the top right such as "1 - 80 of 2264". In order to display the total number, Odoo fetches all IDs and filters out the ids to which the user does not have access. For the JobRad database with more than 32 million entries this causes either a MemoryError or a timeout. The suggested solution is to skip the filtering. This means the total number of entries will be wrong. The list can still be navigated without any issues.
borna-ng
force-pushed
the
jobrad-14.0
branch
5 times, most recently
from
1c33238
to
9dc00d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening the list of attachments, Odoo wants to display the total number of items in the list. This is displayed in the top right such as "1 - 80 of 2264".
In order to display the total number, Odoo fetches all IDs and filters out the ids to which the user does not have access. For the JobRad database with more than 32 million entries this causes either a MemoryError or a timeout.
The suggested solution is to skip the filtering. This means the total number of entries will be wrong. The list can still be navigated without any issues.