Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently galpy wheels for MacOS on PyPI are not compiled with OpenMP because
-fopenmp
is not supported by default clang in the OS but need to use-Xclang=-fopenmp
. This PR provides a fix such that galpy can use OpenMP on MacOS too, also removes unneccessary code to define inline for Windows that usedistutils
which was removed in Python 3.12.A quick sanity check with
nm -g libgalpy.cpython-312-darwin.so
using a galpy wheel on PyPI indeed show OpenMP is not used (missing symbols like_omp_get_max_threads
since v1.8.1).In
setup.py
, I have assumed homebrew is used and set the ibclude/lib path directly. Not sure what is the best way to do this since openmp does not have something likegsl-config --prefix
.The performance test is as follow