MNT Blackify the code base #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good. I moved the lint job to |
This was referenced Sep 17, 2021
ogrisel
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
LGTM but we could also add some config in pyproject.toml similarly to what we do in scikit-learn for instance:
[tool.black]
line-length = 88
target_version = ['py36', 'py37', 'py38', 'py39']
experimental_string_processing = true
to better control the behavior of black in case of changes.
|
I added the config in pyproject.toml. Let's merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed in #95. Done in a separate PR to not interfere with the other changes.