FIX check symbols to better identify supported libraries #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Oct 5, 2023
| return "openmp" | ||
| elif self.dynlib.bli_info_get_enable_pthreads(): | ||
| elif getattr(self.dynlib, "bli_info_get_enable_pthreads", lambda: False)(): |
There was a problem hiding this comment.
because I want to return a bool since it's passed to elif
There was a problem hiding this comment.
Indeed, I misread the line.
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Feb 14, 2024
3.3.0 (2024-02-14) ================== - Extended FlexiBLAS support to be able to switch backend at runtime. joblib/threadpoolctl#163 - Added support for FlexiBLAS joblib/threadpoolctl#156 - Fixed a bug where an unsupported library would be detected because it shares a common prefix with one of the supported libraries. Now the symbols are also checked to identify the supported libraries. joblib/threadpoolctl#151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149
This PR proposes to check that at least 1 of the symbols we're looking for exists the make sure that a library having a matching prefix is actually a supported library (and not a library with a common prefix).
We can't really check that all symbols exist because:
I'm not sure it's worth trying to install a library the used to trigger the bug in our CI just to test that. I did not find an easy way to install bliss for instance (at least, the way I found didn't come with a libbliss dso)...