Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Add support for OpenBLAS built for 64bit integers in Fortran #101

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

jeremiedbb
Copy link
Collaborator

@jeremiedbb jeremiedbb commented Sep 24, 2021

In that case, the symbols are suffixed with 64_.
Fixes #92

I tested locally with the nightly build of numpy (https://anaconda.org/scipy-wheels-nightly/numpy)

Before this PR python -m threadpoolctl -i numpy returned

[
  {
    "user_api": "blas",
    "internal_api": "openblas",
    "prefix": "libopenblas",
    "filepath": "/home/jeremie/miniconda/envs/tst-ctl/lib/python3.8/site-packages/numpy.libs/libopenblas64_p-r0-6d9684d7.3.17.so",
    "version": null,
    "num_threads": null,
    "threading_layer": "unknown",
    "architecture": null
  }
]

And with this PR

[
  {
    "user_api": "blas",
    "internal_api": "openblas",
    "prefix": "libopenblas",
    "filepath": "/home/jeremie/miniconda/envs/tst-ctl/lib/python3.8/site-packages/numpy.libs/libopenblas64_p-r0-6d9684d7.3.17.so",
    "version": "0.3.17",
    "num_threads": 4,
    "threading_layer": "pthreads",
    "architecture": "Haswell"
  }
]

(I also checked that the set_num_threads also works as expected).

If numpy/scipy eventually release with this build of OpenBLAS, the CIs with the latest versions of the packages will get this build of OpenBLAS, enabling the tests for the added code in this PR.

Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much!

@ogrisel ogrisel merged commit d14aea1 into joblib:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle OpenBLAS built for 64bit integers in Fortran
2 participants