-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyright cannot work with eglot #768
Comments
Thanks for the nice issue report. I think I have everything I need here. |
I got the same issue on Windows 10 with Emacs 29.0.50 + eglot latest master branch When a execute
Messages on `EGLOT (python/pyton-mode) events buffer
When I enable
my eglot config: (use-package eglot
:defer t
:bind (:map eglot-mode-map
("C-c l a" . eglot-code-actions)
("C-c l r" . eglot-rename)
("C-c l f" . eglot-format)
("C-c l d" . eldoc))
:hook (eglot-managed-mode . (lambda () (flymake-mode -1)))
:config
(add-to-list 'eglot-server-programs '(rust-mode "rust-analyzer"))
(add-to-list 'eglot-server-programs '((c++-mode c-mode) "clangd"))
(setq read-process-output-max (* 1024 1024))
(push :documentHighlightProvider eglot-ignored-server-capabilities)
(setq eldoc-echo-area-use-multiline-p nil))
The same config works well on Mac and Arch Linux |
Thanks, again this contains an actual error with a backtrace so it shouldn't be very hard to pinpoint. However I've not had time to look at this. Seems to be triggered by |
In fact, I install the latest eglot from melpa, and enable it with pyright server in a simple python project. This problem I report seems disappear but a new error raised. It shows in my echo area frequently that "error in process filter: [eglot] A `Diagnostic' mustn't have (:codeDescription)". :( |
Could you report that as a new issue with the full details? Thanks! |
@joaotavora Thanks for your advice. Now, I figure out what cause this issue on Windows system. Fixed it by : Download the right findutils and put it in the system path, and now eglot works well on Windows.
|
…ption A codeDescription property is, at the time of writing, an object with an href property (of type URI, or a string), denoting a "URI to open with more information about the diagnostic error". It's not obvious how best to put this into a Flymake diagostic aside from simply appending it to the diagnostic message, so we'll worry about it some other time.
…ption A codeDescription property is, at the time of writing, an object with an href property (of type URI, or a string), denoting a "URI to open with more information about the diagnostic error". It's not obvious how best to put this into a Flymake diagostic aside from simply appending it to the diagnostic message, so we'll worry about it some other time.
…cription A codeDescription property is, at the time of writing, an object with an href property (of type URI, or a string), denoting a "URI to open with more information about the diagnostic error". It's not obvious how best to put this into a Flymake diagostic aside from simply appending it to the diagnostic message, so we'll worry about it some other time. * eglot.el (eglot--lsp-interface-alist) (eglot-client-capabilities): Don't error out on unsupported Diagnostic.codeDescription.
A codeDescription property is, at the time of writing, an object with an href property (of type URI, or a string), denoting a "URI to open with more information about the diagnostic error". It's not obvious how best to put this into a Flymake diagostic aside from simply appending it to the diagnostic message, so we'll worry about it some other time. * eglot.el (eglot--lsp-interface-alist) (eglot-client-capabilities): Don't error out on unsupported Diagnostic.codeDescription.
…odeDescription A codeDescription property is, at the time of writing, an object with an href property (of type URI, or a string), denoting a "URI to open with more information about the diagnostic error". It's not obvious how best to put this into a Flymake diagostic aside from simply appending it to the diagnostic message, so we'll worry about it some other time. * eglot.el (eglot--lsp-interface-alist) (eglot-client-capabilities): Don't error out on unsupported Diagnostic.codeDescription.
…odeDescription A codeDescription property is, at the time of writing, an object with an href property (of type URI, or a string), denoting a "URI to open with more information about the diagnostic error". It's not obvious how best to put this into a Flymake diagostic aside from simply appending it to the diagnostic message, so we'll worry about it some other time. * eglot.el (eglot--lsp-interface-alist) (eglot-client-capabilities): Don't error out on unsupported Diagnostic.codeDescription.
A codeDescription property is, at the time of writing, an object with an href property (of type URI, or a string), denoting a "URI to open with more information about the diagnostic error". It's not obvious how best to put this into a Flymake diagostic aside from simply appending it to the diagnostic message, so we'll worry about it some other time. * eglot.el (eglot--lsp-interface-alist) (eglot-client-capabilities): Don't error out on unsupported Diagnostic.codeDescription. #768: joaotavora/eglot#768
A codeDescription property is, at the time of writing, an object with an href property (of type URI, or a string), denoting a "URI to open with more information about the diagnostic error". It's not obvious how best to put this into a Flymake diagostic aside from simply appending it to the diagnostic message, so we'll worry about it some other time. * eglot.el (eglot--lsp-interface-alist) (eglot-client-capabilities): Don't error out on unsupported Diagnostic.codeDescription. GitHub-reference: fix joaotavora/eglot#768
A codeDescription property is, at the time of writing, an object with an href property (of type URI, or a string), denoting a "URI to open with more information about the diagnostic error". It's not obvious how best to put this into a Flymake diagostic aside from simply appending it to the diagnostic message, so we'll worry about it some other time. * eglot.el (eglot--lsp-interface-alist) (eglot-client-capabilities): Don't error out on unsupported Diagnostic.codeDescription. GitHub-reference: fix joaotavora/eglot#768
LSP transcript - M-x eglot-events-buffer (mandatory unless Emacs inoperable)
Backtrace (mandatory, unless no error message seen or heard):
Minimal configuration (mandatory)
# Type this in a shell to start an Emacs with Eglot configured $ /path/to/a/certain/version/of/emacs -Q -f package-initialize -L /path/to/git-cloned/eglot -l eglot.el
When M-x
eglot
for a python file buffer, these is a message in the message area:[eglot] (warning) Not auto-reconnecting, last one didn't last long.
Additional information:
python --version: 3.9.9
pyright --version: 1.1.193
The text was updated successfully, but these errors were encountered: