Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now display a localized decimal separator. #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mgriebling
Copy link

I've added code so that the decimal separator is localized.
It seems to work on a Mac when switching the regions here in Canada.

@joachimneumann
Copy link
Owner

Hello,

I am happy to see that someone joined this open source project 😍.

Until now I have been the only developer and I have been a bit careless with respect to repositories, branches and git commit comments.

I can merge your code, no problem, but I am actually now working on a new version.

You can find this in the repository called Calculator in the branch Mac.

I would be happy if you could have a look into this.

In this code, the decimal separator is configurable in the settings and (haven't tested that) the default should correspond to the locale.

This repository should also work better on iPhone, iPad and Mac.

However, there is currently a stupid bug with the processing state, so calculating might not work at the moment, but I plan to fix that soon.

Let me know what you to think.

@mgriebling
Copy link
Author

mgriebling commented Mar 17, 2023

I tried the new Mac branch and it seems to be missing the gmp/mpfr frameworks.
I can copy those from your other calculator branch and upload the changes to the Mac branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants