Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major changes to support latest Assetto Corsa version #36

Open
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

Pringlez
Copy link
Contributor

Changed the way track config loading is done, it relies on local images & json files instead of contentPath. This will be helpful for linux installation.

Fixed some HTML issues, tags, clean up & updated help page image.

Changed server.js inconsistencies related to quotes.

Updated messages displayed to user, nicer output :)

Tested on Windows, seems to all work fine. Will test on my Linux install later...

Changed the way track config loading is done, it relies on local images & json files instead of contentPath. This will be helpful for linux installation.

Fixed some HTML issues, tags, clean up & updated help page image.

Changed server.js inconsistencies related to quotes.

Updated messages displayed to user, nicer output :)

Tested on Windows, seems to all work fine. Will test on my Linux install later...
@Pringlez
Copy link
Contributor Author

Tested on Linux installation @jo3stevens , seems to work just fine. Track images load fine & config layouts of tracks.

@Cele91
Copy link

Cele91 commented May 14, 2017

Negative. If I select "club" of Vallelunga, after refresh it appear "classic"

@Pringlez
Copy link
Contributor Author

I have a fix for that, I'm working on fixing other save issues when I get time

More commits to come, to finish changes later

Drop track select fixed
Updated angular verion etc
@Pringlez
Copy link
Contributor Author

Hey @jo3stevens

I've removed the sun angle calculation because it doesn't seem to populate the UI HRs & MMs fields if for instance the sun angle is set to '-8' or lower, I'm still looking into.

The reason why I removed the 'min' value from that field is because it was preventing the form validating & saving the data from what I found.

The track & car content is not available on a remote Linux server, so this allows server admins use a 'local' copy of the content on a remote machine that has no access to an installation of Assetto Corsa. You can disable this by setting the 'useLocalContent' to false.

I've updated the Angular version & removed some JS files not in use anymore.

I plan to clean up these commits with another one, I've just noticed some logs got in there....

Added the new configuration settings for wind & time of day

Fixed a issues with 'Locked Entry List', 'Loop Session', 'Pickup Mode Enabled' & 'Register to Lobby' not switching to the correct button value

Reverted Sun Angle calculation & added in option to either set the sun angle directly or with hours & mins fields

Updated readme & version number

Working on local Windows machine
@Pringlez
Copy link
Contributor Author

I believe I fixed most of the saving issues with my last commit just there.

The local content I added is only about 5mb, only small ini & json files were added. It's a real headache to get this content onto a remote Linux server by copying stuff over ssh. I know it may look messy & requires some ongoing maintenance as new tracks and cars get added, but it would be a hell of alot easier for Linux hosting 👍

John W

Pringlez and others added 15 commits May 24, 2017 04:21
Small fix for cars API because local content for cars has not been commited to repo.
* Add support for uploading both single and multilayout tracks using
  drag & drop
* Add support for removing existing tracks and cars
Update content for v1.16, add linux frontend content generation scripts for cars / skins
Tracks and cars management, merging to master

Tested on Linux, seems to work without issues, templates work fine + all other functionality seems to work fine. Drag & drop feature works quite well!

Some code indentation clean up required in some files
To keep things consistent & bumped version number
@Pringlez Pringlez changed the title Changed track UI loading & other changes Major changes to support latest Assetto Corsa version Jan 16, 2018
@Pringlez
Copy link
Contributor Author

Hey @jo3stevens,

It's been awhile, would you like to take a look at the latest version of the fork? There has been quite a few updates since last time 👍

Cheers
John W

hmehta and others added 5 commits April 3, 2018 19:46
This helps administrators to more easily configure Steam GUIDs, ballasts
and such for drivers participating regularly to a series of races.
@TylerBre
Copy link

@Pringlez issue was with a node fn fs.copyFileSync

https://nodejs.org/api/fs.html#fs_fs_copyfilesync_src_dest_flags

essentially this makes your code have a hard requirement for node >= v8.5.0

I would recommend putting that in package.json via engines block and engineStrict:

http://www.marcusoft.net/2015/03/packagejson-and-engines-and-enginestrict.html

@TylerBre
Copy link

TylerBre commented May 30, 2018

@jo3stevens will this ever be merged in? It has a number of good bug fixes and useful functionality.

I want to put this into a docker image but I don't like that it's just a pr, wish it was on a stable branch, etc.

@Pringlez
Copy link
Contributor Author

@TylerBre I'm not sure if the engines block and engineStrict is supported anymore, since node version 3+ I think it has been deprecated. Is that correct?
Maybe I should update the readme to highlight the issue.

@TylerBre
Copy link

TylerBre commented May 30, 2018

@Pringlez engines definitely is, https://docs.npmjs.com/files/package.json#engines

Personally I've never used enginesStrict, but I've used npm scripts that will check your locally installed node version and exit the process if your node version doesn't match up with what's in package.json

Or you could just shim copyFileSync with a node module or something

@Pringlez
Copy link
Contributor Author

@TylerBre Feel free to implement a fix & pull request 👍 . I could look into later if I get time. I'll just update the readme for now. Good work finding the issue there. Maybe @hmehta could help you out since he implemented the feature 👍

Pringlez and others added 2 commits May 30, 2018 22:38
Node version 8.5.0 or newer is now preferred
@TylerBre
Copy link

@Pringlez done:

Pringlez#14

Pringlez and others added 2 commits May 31, 2018 22:08
Using fs-copy-file-sync over fs.copyFileSync for backwards compatability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants