Merge pull request #218 from dwnichols/master

Updating the handling of Set-Cookie in http responses

lib/httparty/cookie_hash.rb

@@ -8,7 +8,7 @@ def add_cookies(value)
       merge!(value)
     when String
       value.split('; ').each do |cookie|
-        array = cookie.split('=')
+        array = cookie.split('=',2)
         self[array[0].to_sym] = array[1]
       end
     else

lib/httparty/request.rb

@@ -290,7 +290,7 @@ def capture_cookies(response)
       return unless response['Set-Cookie']
       cookies_hash = HTTParty::CookieHash.new()
       cookies_hash.add_cookies(options[:headers]['Cookie']) if options[:headers] && options[:headers]['Cookie']
-      cookies_hash.add_cookies(response['Set-Cookie'])
+      response.get_fields('Set-Cookie').each { |cookie| cookies_hash.add_cookies(cookie) }
       options[:headers] ||= {}
       options[:headers]['Cookie'] = cookies_hash.to_cookie_string
     end

spec/httparty/cookie_hash_spec.rb

@@ -35,6 +35,13 @@
         @cookie_hash.length.should eql(1)
         @cookie_hash[:foo].should eql("tar")
       end
+
+      it "should handle '=' within cookie value" do
+          @cookie_hash.add_cookies("first=one=1; second=two=2==")
+          @cookie_hash.keys.should include(:first, :second)
+          @cookie_hash[:first].should == 'one=1'
+          @cookie_hash[:second].should == 'two=2=='
+      end
     end
 
     describe 'with other class' do

spec/httparty/request_spec.rb

@@ -495,6 +495,16 @@
         @request.options[:headers]['Cookie'].should match(/keep=me/)
       end
 
+      it "should handle multiple Set-Cookie headers between redirects" do
+        @redirect.add_field 'set-cookie', 'foo=bar; name=value; HTTPOnly'
+        @redirect.add_field 'set-cookie', 'one=1; two=2; HTTPOnly'
+        @request.perform
+        @request.options[:headers]['Cookie'].should match(/foo=bar/)
+        @request.options[:headers]['Cookie'].should match(/name=value/)
+        @request.options[:headers]['Cookie'].should match(/one=1/)
+        @request.options[:headers]['Cookie'].should match(/two=2/)
+      end
+
       it 'should make resulting request a get request if it not already' do
         @request.http_method = Net::HTTP::Delete
         @request.perform.should == {"hash" => {"foo" => "bar"}}