ssl_version option is only available in Ruby 1.9.

jnunemaker · Aug 20, 2012 · 6b88a95 · 6b88a95
1 parent c2cf65f
commit 6b88a95
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/lib/httparty.rb b/lib/httparty.rb
@@ -296,7 +296,7 @@ def query_string_normalizer(normalizer)
       default_options[:query_string_normalizer] = normalizer
     end
 
-    # Allows setting of SSL version to use.
+    # Allows setting of SSL version to use. This only works in Ruby 1.9.
     # You can get a list of valid versions from OpenSSL::SSL::SSLContext::METHODS.
     #
     #   class Foo

diff --git a/lib/httparty/request.rb b/lib/httparty/request.rb
@@ -114,7 +114,7 @@ def attach_ssl_certificates(http)
           http.verify_mode = OpenSSL::SSL::VERIFY_PEER
         end
 
-        if options[:ssl_version]
+        if options[:ssl_version] && http.respond_to?(:ssl_version=)
           http.ssl_version = options[:ssl_version]
         end
       end

diff --git a/spec/httparty/request_spec.rb b/spec/httparty/request_spec.rb
@@ -167,7 +167,10 @@
 
     it 'uses specified ssl_version' do
       request = HTTParty::Request.new(Net::HTTP::Get, 'https://foobar.com', :ssl_version => :TLSv1)
-      request.send(:http).ssl_version.should == :TLSv1
+      http = request.send(:http)
+      if http.respond_to?(:ssl_version)
+        http.ssl_version.should == :TLSv1
+      end
     end
 
     context "PEM certificates" do