Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Pin xlrd to the 1.* serie #356

Merged
merged 1 commit into from
Feb 5, 2021
Merged

PR: Pin xlrd to the 1.* serie #356

merged 1 commit into from
Feb 5, 2021

Conversation

jnsebgosselin
Copy link
Owner

Xlrd 2.x series does not support reading xlsx type files unlike the 1.x series.

see https://github.com/python-excel/xlrd:

This library will no longer read anything other than .xls files. For alternatives that read newer file formats, please see http://www.python-excel.org/.

We get an error when trying to read this type of file now, which is rather problematic. So we are going to pin xlrd to the 1.x series for the time being until we switch properly to another package to read xlsx files.

@jnsebgosselin jnsebgosselin self-assigned this Feb 5, 2021
@jnsebgosselin jnsebgosselin added this to the gwhat-0.5.1 milestone Feb 5, 2021
@jnsebgosselin jnsebgosselin merged commit 1d2c509 into master Feb 5, 2021
@jnsebgosselin jnsebgosselin deleted the pin_xlrd_version branch February 5, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant