Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add a user config system to GWHAT #294

Merged
merged 10 commits into from
Oct 7, 2019
Merged

PR: Add a user config system to GWHAT #294

merged 10 commits into from
Oct 7, 2019

Conversation

jnsebgosselin
Copy link
Owner

@jnsebgosselin jnsebgosselin commented Oct 7, 2019 •
edited
Loading

The goal of this PR is to use AppConfigs to manage user configurations in GWHAT instead of the current, broken, system that is used.

@jnsebgosselin jnsebgosselin added this to the gwhat-0.4.0 milestone Oct 7, 2019
@jnsebgosselin jnsebgosselin self-assigned this Oct 7, 2019
@pep8speaks
Copy link

pep8speaks commented Oct 7, 2019 •
edited
Loading

Hello @jnsebgosselin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 53:1: E402 module level import not at top of file
Line 54:1: E402 module level import not at top of file

Line 19:1: E402 module level import not at top of file
Line 20:1: E402 module level import not at top of file

Comment last updated at 2019-10-07 18:41:52 UTC

@jnsebgosselin jnsebgosselin merged commit 0adb356 into master Oct 7, 2019
@jnsebgosselin jnsebgosselin deleted the add_config_system branch October 7, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jnsebgosselin jnsebgosselin

Labels
component: Main type: enhancement
Projects
None yet
Milestone
gwhat-0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jnsebgosselin @pep8speaks