Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Break some inter-dependences of tests across modules #245

Merged
merged 18 commits into from
Dec 21, 2018
Merged

PR: Break some inter-dependences of tests across modules #245

merged 18 commits into from
Dec 21, 2018

Conversation

jnsebgosselin
Copy link
Owner

@jnsebgosselin jnsebgosselin commented Dec 21, 2018 •
edited
Loading

The idea is to gradually remove the inter-dependence between the tests to make writing new tests easier and to increase maintainability.

  • Refactored test_hydroprint.py
  • Refactored test_manager_data.py
  • Refactored test_hydrocalc.py

@jnsebgosselin jnsebgosselin added this to the gwhat-0.3.4 milestone Dec 21, 2018
@jnsebgosselin jnsebgosselin self-assigned this Dec 21, 2018
@pep8speaks
Copy link

Hello @jnsebgosselin! Thanks for submitting the PR.

@jnsebgosselin jnsebgosselin changed the title PR: Make the tests for the DataManager standalone PR: Break the inter-dependence of the tests across modules Dec 21, 2018
@jnsebgosselin jnsebgosselin changed the title PR: Break the inter-dependence of the tests across modules PR: Break some inter-dependences of tests across modules Dec 21, 2018
@jnsebgosselin jnsebgosselin merged commit 484b1a7 into master Dec 21, 2018
@jnsebgosselin jnsebgosselin deleted the make_datamanger_test_independents branch December 21, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jnsebgosselin jnsebgosselin

Labels
component: Data Manager tag: continuous integration type: maintenance
Projects
None yet
Milestone
gwhat-0.3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jnsebgosselin @pep8speaks