-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Move normal weather toolbutton from the hydrograph editor toolbar to the weather data manager toolbar #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @jnsebgosselin! Thanks for submitting the PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #216 and should also Fixes #152
This has proven to be a little bit more work to implement than what was initially expected. By adding a new icon next the the weather datasets combobox, there was just not enough horizontal space anymore for the combobox.
So, the toolbar had to be split in two row. But, by doing that, this was aggravating furthermore Issue #152. The solution was to rethink how the infos of the currently selected water level and weather datasets are displayed in the UI. So instead of using a simple
QTextEdit
box, we now use a customSpinBox
that can be used to circle through the characteristics of the selected datasets, while taking up only one line of space.In a future update, a button will be added next to the info spinbox that, when clicked, will pop-up a borderless window that will show all the infos of the selected dataset at once.
Now
Before