Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Move normal weather toolbutton from the hydrograph editor toolbar to the weather data manager toolbar #220

Merged
merged 22 commits into from
May 16, 2018

Conversation

jnsebgosselin
Copy link
Owner

@jnsebgosselin jnsebgosselin commented May 16, 2018

Fixes #216 and should also Fixes #152

This has proven to be a little bit more work to implement than what was initially expected. By adding a new icon next the the weather datasets combobox, there was just not enough horizontal space anymore for the combobox.

So, the toolbar had to be split in two row. But, by doing that, this was aggravating furthermore Issue #152. The solution was to rethink how the infos of the currently selected water level and weather datasets are displayed in the UI. So instead of using a simple QTextEdit box, we now use a custom SpinBox that can be used to circle through the characteristics of the selected datasets, while taking up only one line of space.

In a future update, a button will be added next to the info spinbox that, when clicked, will pop-up a borderless window that will show all the infos of the selected dataset at once.

Now

show_weather

Before

image

@pep8speaks
Copy link

Hello @jnsebgosselin! Thanks for submitting the PR.

Line 785:80: E501 line too long (83 > 79 characters)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants