try loading the library with System.loadLibrary()
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some environments have their own way to ship native libraries (e.g., Android). On those it is preferrable to rely on System.loadLibrary instead of manually ]extracting/loading the library from resources
|
This seems like a fine thing to add, but if the other forms of loading fail couldn't we put this at the end of the method? My concern is that by putting this at the front of the list, we defer all searching and loading to the JVM first, which may cause it to load a library from a default location rather than a location configured by a user (which is important on secure systems). Can you get the same effect moving the |
|
No follow-up so I have not merged this. Still willing to consider it! |
|
@headius, my apologies, I lost track of this. Yes, moving it to the end also works, and the security considerations make sense 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some environments have their own way to ship native libraries (e.g., Android).
On those it is preferrable to rely on System.loadLibrary instead of manually
extracting/loading the library from resources