Enabled support for mBeans with non-string typed keys #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billonahill
reviewed
Feb 2, 2021
| if (key == null) { | ||
| // Get for all keys | ||
| for (Map.Entry<String, Object> entry : mapData.entrySet()) { | ||
| String key = entry.getKey(); | ||
| for (Map.Entry<Object, Object> entry : mapData.entrySet()) { |
There was a problem hiding this comment.
Instead of a specific one-off to support doubles, could we instead just toString the key before adding/getting and keep the key as a String? That seems cleaner and would work for other types.
There was a problem hiding this comment.
I believe this already supports all types since Java Objects must implement toString(). (Double is just an example type covered in tests)
There was a problem hiding this comment.
ic. we're just casting the mbean map type more generically. I initially thought this change was being exposed more so than it is. My bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.