Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naming issues with sbref #28

Closed
oricon opened this issue Mar 5, 2018 · 2 comments
Closed

naming issues with sbref #28

oricon opened this issue Mar 5, 2018 · 2 comments
Assignees
Labels

Comments

@oricon
Copy link

oricon commented Mar 5, 2018

I have singleband reference images (one per multiband func run) that I'm trying to convert, but I'm running into naming trouble. I've setup Protocol_Translator as follows:

"ritl_pa_32ch_mb8_v01_r01_SBRef":[
        "func",
        "task-ritl_acq-SB_run-01_sbref",
        "task-ritl_acq-MB_run-01_bold"
    ],
    "ritl_pa_32ch_mb8_v01_r01":[
        "func",
        "task-ritl_acq-MB_run-01_bold",
        "UNASSIGNED"
    ],

But they are being named as if the sbref are duplicates of the bold images:
sub-M80301092_task-ritl_acq-MB_run-01_run-01_bold.nii.gz
sub-M80301092_task-ritl_acq-MB_run-02_run-01_bold.nii.gz
sub-M80301092_task-ritl_acq-MB_run-03_run-01_bold.nii.gz
sub-M80301092_task-ritl_acq-MB_run-04_run-01_bold.nii.gz
sub-M80301092_task-ritl_acq-MB_run-05_run-01_bold.nii.gz
sub-M80301092_task-ritl_acq-MB_run-06_run-01_bold.nii.gz
sub-M80301092_task-ritl_acq-SB_run-01_run-02_sbref.nii.gz
sub-M80301092_task-ritl_acq-SB_run-02_run-02_sbref.nii.gz
sub-M80301092_task-ritl_acq-SB_run-03_run-02_sbref.nii.gz
sub-M80301092_task-ritl_acq-SB_run-04_run-02_sbref.nii.gz
sub-M80301092_task-ritl_acq-SB_run-05_run-02_sbref.nii.gz
sub-M80301092_task-ritl_acq-SB_run-06_run-02_sbref.nii.gz

I've tried w/o the IntendedFor field and I get the same result. Is this a bug/issue or am I defining them incorrectly?

Thanks,
Joe

@jmtyszka
Copy link
Owner

jmtyszka commented Mar 5, 2018

Hi Joe - this is a bug. I have time this week to work on this and the other active issues, so I'll hopefully have a fix for you to try out by next week. Thanks for raising this.

@jmtyszka jmtyszka added the bug label Mar 5, 2018
@jmtyszka jmtyszka self-assigned this Mar 5, 2018
jmtyszka added a commit that referenced this issue Mar 9, 2018
…grated to pydicom v1.0.1 (note namespace change to pydicom).
@jmtyszka
Copy link
Owner

jmtyszka commented Mar 9, 2018

I've just pushed a new version (v1.1.0) which fixes this bug. The duplicate series counting logic has been updated and now correctly recognizes the difference between a BOLD EPI timeseries and its associated SBRef (auto generated by the CMRR MB sequence). If a run-* value is present in the protocol translator BIDS filename template, this is preserved and not overwritten. If a series description occurs only once in the session, no run-* field is added to the BIDS filename suffix.

@jmtyszka jmtyszka closed this as completed Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants