Better STM32 Tone timer int priority (MarlinFirmware#18385)

jmp0x0000 · Aug 7, 2020 · 0281c19 · 0281c19
1 parent 5ea8799
commit 0281c19
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/Marlin/src/HAL/STM32/timers.cpp b/Marlin/src/HAL/STM32/timers.cpp
@@ -36,6 +36,15 @@
   #define TEMP_TIMER_IRQ_PRIO 14   // 14 = after hardware ISRs
 #endif
 
+// Ensure the default timer priority is somewhere between the STEP and TEMP priorities.
+// The STM32 framework defaults to interrupt 14 for all timers. This should be increased so that
+// timing-sensitive operations such as speaker output are note impacted by the long-running
+// temperature ISR. This must be defined in the platformio.ini file or the board's variant.h,
+// so that it will be consumed by framework code.
+#if !(TIM_IRQ_PRIO > STEP_TIMER_IRQ_PRIO && TIM_IRQ_PRIO < TEMP_TIMER_IRQ_PRIO)
+  #error "Default timer interrupt priority is unspecified or set to a value which may degrade performance."
+#endif
+
 #if HAS_TMC_SW_SERIAL
   #include <SoftwareSerial.h>
   #ifndef SWSERIAL_TIMER_IRQ_PRIO

diff --git a/platformio.ini b/platformio.ini
@@ -329,6 +329,7 @@ build_flags   = ${common.build_flags}
   -IMarlin/src/HAL/STM32 -std=gnu++14
   -DUSBCON -DUSBD_USE_CDC
   -DUSBD_VID=0x0483
+  -DTIM_IRQ_PRIO=13
 build_unflags = -std=gnu++11
 src_filter    = ${common.default_src_filter} +<src/HAL/STM32>