Skip to content

Commit

Permalink
FIXUP: Reference bazelbuild#43.
Browse files Browse the repository at this point in the history
  • Loading branch information
jmmv committed Oct 31, 2018
1 parent 99e76b5 commit 4a56fcb
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
9 changes: 5 additions & 4 deletions src/nodes/conv.rs
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,11 @@ pub fn attr_fs_to_fuse(path: &Path, inode: u64, attr: &fs::Metadata) -> fuse::Fi
attr.len()
};

// TODO(jmmv): Using the underlying ctimes is slightly wrong because the ctimes track changes
// to the inodes. In most cases, operations that flow via sandboxfs will affect the underlying
// ctime and propagate through here, which is fine, but other operations are purely in-memory.
// To properly handle those cases, we should have our own ctime handling.
// TODO(https://github.com/bazelbuild/sandboxfs/issues/43): Using the underlying ctimes is
// slightly wrong because the ctimes track changes to the inodes. In most cases, operations
// that flow via sandboxfs will affect the underlying ctime and propagate through here, which is
// fine, but other operations are purely in-memory. To properly handle those cases, we should
// have our own ctime handling.
let ctime = Timespec { sec: attr.ctime(), nsec: attr.ctime_nsec() as i32 };

let perm = match attr.permissions().mode() {
Expand Down
3 changes: 2 additions & 1 deletion src/nodes/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ pub type NodeResult<T> = Result<T, KernelError>;
/// kernel, as computing the updated metadata here would be inaccurate. The reason is that we don't
/// track ctimes ourselves so any modifications to the file cause the backing ctime to be updated
/// and we need to obtain it.
/// TODO(jmmv): Compute the modified fuse::FileAttr and return it once we track ctimes.
/// TODO(https://github.com/bazelbuild/sandboxfs/issues/43): Compute the modified fuse::FileAttr and
/// return it once we track ctimes.
///
/// This tries to apply as many properties as possible in case of errors. When errors occur,
/// returns the first that was encountered.
Expand Down

0 comments on commit 4a56fcb

Please sign in to comment.