Fallback layer avoid calling SetComputeRoot32BitConstants with no data (

microsoft#800) If AccelerationStructuresEntries is empty, don't call SetComputeRoot32BitConstants
jmkinzer · Oct 12, 2022 · b6031f6 · b6031f6
1 parent 1f7da32
commit b6031f6
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/Libraries/D3D12RaytracingFallback/src/UberShaderRayTracingProgram.cpp b/Libraries/D3D12RaytracingFallback/src/UberShaderRayTracingProgram.cpp
@@ -258,8 +258,11 @@ namespace FallbackLayer
             AccelerationStructuresEntries[entriesAdded++] = entry.second;
         }
 
-        pCommandList->SetComputeRoot32BitConstants(
-            m_patchRootSignatureParameterStart + AccelerationStructuresList, (UINT)(AccelerationStructuresEntries.size() * (SizeOfInUint32(*AccelerationStructuresEntries.data()))), AccelerationStructuresEntries.data(), 0);
+        if (!AccelerationStructuresEntries.empty())
+        {
+            pCommandList->SetComputeRoot32BitConstants(
+                m_patchRootSignatureParameterStart + AccelerationStructuresList, (UINT)(AccelerationStructuresEntries.size() * (SizeOfInUint32(*AccelerationStructuresEntries.data()))), AccelerationStructuresEntries.data(), 0);
+        }
 
 #ifdef DEBUG
         m_pPredispatchCallback(pCommandList, m_patchRootSignatureParameterStart);