Fix chat #193
Merged
Fix chat #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where all previous chats would disappear when any user sends a new message. This happened because the cache would trim itself down to 1000 messages at every message, but it would do this for bot messages and chat messages combined. There were a lot of bot messages, so it would fill that limit quickly and chats would disappear.
Current fix is to separate the bot and chat messages in the cache, and limit them individually to 1000. This works but the whole thing really needs to be reworked from the ground up as it's just a big pile of feature creep with zero plan from the start. Another day.