GetCart should be async? (open-telemetry#372)

Co-authored-by: Carter Socha <[email protected]>
jmichalak9 · Sep 23, 2022 · 5a7d1d0 · 5a7d1d0
1 parent e6eb3a4
commit 5a7d1d0
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/cartservice/src/services/CartService.cs b/src/cartservice/src/services/CartService.cs
@@ -41,15 +41,16 @@ public async override Task<Empty> AddItem(AddItemRequest request, ServerCallCont
             return Empty;
         }
 
-        public override Task<Cart> GetCart(GetCartRequest request, ServerCallContext context)
+        public async override Task<Cart> GetCart(GetCartRequest request, ServerCallContext context)
         {
             var activity = Activity.Current;
             activity?.SetTag("app.user.id", request.UserId);
             activity?.AddEvent(new("Fetch cart"));
 
-            var cart = _cartStore.GetCartAsync(request.UserId);
+            var cart = await _cartStore.GetCartAsync(request.UserId);
             var totalCart = 0;
-            foreach (CartItem item in cart.Result.Items) {
+            foreach (var item in cart.Items)
+            {
                 totalCart += item.Quantity;
             }
             activity?.SetTag("app.cart.items.count", totalCart);