Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix integer number processing #6

Merged
merged 1 commit into from
Nov 26, 2015
Merged

fix integer number processing #6

merged 1 commit into from
Nov 26, 2015

Conversation

flisky
Copy link
Contributor

@flisky flisky commented Nov 23, 2015

go-jmespath only expects json.Number as float64

go-jmespath only expects json.Number as float64
@jamesls
Copy link
Member

jamesls commented Nov 23, 2015

Taking a look. I wonder if it's possible to also preserve the behavior of not printing scientific notation for large numbers.

@jamesls jamesls added the bug label Nov 23, 2015
@flisky
Copy link
Contributor Author

flisky commented Nov 24, 2015

encoding/json acts this way as intended (Refer golang/go#5562), so I'm afraid that we cannot implement it until the underlying library distinguishes int64 & float64 for us.

@jamesls
Copy link
Member

jamesls commented Nov 26, 2015

That's too bad. I'm looking into a few other options, most of which seem to involve not using the unmarshaller directly from encoding/json. This isn't going to be a quick fix so for now I'll pull in this change and reopen #3.

jamesls added a commit that referenced this pull request Nov 26, 2015
fix integer number processing
@jamesls jamesls merged commit 7a8248e into jmespath:master Nov 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants