-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix module definition and load sequencing #111
Conversation
@kryptt How has the way modules are accessed been changed in angular 1.2.x? I can't find anything in angular's changelog that would indicate a breaking change. |
@jmdobry You're right, it's only happening under my own setup. I'm loading things through requireJS and it could be related to this somehow. |
I worked on the plunker and made things load through requireJS and the error still doesn't show up angularAMD: Here is a plunker that reproduces the problem I am encountering: Apparently it's issue #3 for that project... |
@kryptt So this pull request is unnecessary and you'll wait for marcoslin/angularAMD#3 to be fixed or submit a PR there? |
Yes, it is unnecessary. It's up to you whether or not to keep the semantics in this PR. I'll try to make some time to look further into marcoslin/angularAMD#3 .. thanks, for the support and quick reply!! :D |
If I were to make a case for this semantic then: It is theoretically faster to use the result of registration right away, as opposed to discarding it, and then making a new search among the registered modules... |
I was planning on merging your pull request later today. |
Fix module definition and load sequencing
angular-cache 2.3.3 refuses to load with angular 1.2.16 the way modules are accessed has been changed since then.