Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README has incorrect examples of time spans #59

Closed
marplesoft opened this issue Oct 3, 2013 · 1 comment
Closed

README has incorrect examples of time spans #59

marplesoft opened this issue Oct 3, 2013 · 1 comment
Assignees
@jmdobry
Labels
3 - Done docs
Milestone
2.0.0-rc.1

Comments

@marplesoft
Copy link

There's several places in the README where you have an example of setting the maxAge option like this:

maxAge: 90000, // Items added to this cache expire after 15 minutes

You are missing a zero. This is actually 1.5 mins, not 15 mins. You do this in several other places with a similar claim that 600000 = 10mins.
@ghost ghost assigned jmdobry Oct 3, 2013
@jmdobry
Copy link
Owner

jmdobry commented Oct 3, 2013

Oops. Should've used a calculator. Good thing I'm not a cashier.

Good catch.

@jmdobry jmdobry mentioned this issue Oct 6, 2013
Merged
14 tasks
jmdobry added a commit that referenced this issue Oct 14, 2013
@jmdobry
Fixed #56. Fixed #59.
a955c52
@jmdobry jmdobry closed this as completed Oct 14, 2013
@jmdobry jmdobry mentioned this issue Oct 14, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmdobry jmdobry

Labels
3 - Done docs
Projects
None yet
Milestone
2.0.0-rc.1
Development

No branches or pull requests
2 participants
@marplesoft @jmdobry