Issue #645 add sonoff trvzb #651
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcollin78
force-pushed
the
issue_645---add-Sonoff-TRVZB
branch
from
9dfdff9
to
5b64a8f
Compare
alexdrans
reviewed
Nov 21, 2024
|
Thank you @alexdrans ! |
Fix hvac_action calculation
Fix offset_calibration=room_temp - (local_temp - current_offset)
Co-authored-by: Alexander Dransfield <[email protected]>
jmcollin78
force-pushed
the
issue_645---add-Sonoff-TRVZB
branch
from
c7db788
to
ffb976c
Compare
added 9 commits
November 23, 2024 10:08
added 8 commits
November 25, 2024 22:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of the POV for Sonoff TRVZB as described here: #645
For review and testing in real life (I cannot do that).