Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure app is closed using try/finally #1211

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Ekman
Copy link

@Ekman Ekman commented Dec 11, 2024

When calling CommandFactory.run(), ensure that the app is closed by wrapping it in a try/finally clause.

When calling `CommandFactory.run()`, ensure that the app is closed by wrapping it in a try/finally clause.
Copy link

changeset-bot bot commented Dec 11, 2024

⚠️ No Changeset found

Latest commit: 6b75e0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jmcdo29
Copy link
Owner

jmcdo29 commented Dec 18, 2024

Could you please add a changeset for this change via pnpm changeset and following the wizard? This change looks like it should be a patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants