Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex path variables #167

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

jdietrich-tc
Copy link
Contributor

adds new optional field to request object: pathVariables
it is a map of the path variable names (without the leading :) to the regexps that they must match

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 66.27%. Comparing base (0745469) to head (af88c6b).
Report is 35 commits behind head on master.

❗ Current head af88c6b differs from pull request most recent head dc97091. Consider uploading reports for the commit dc97091 to get more accurate results

Files Patch % Lines
pkg/route/route.go 0.00% 12 Missing ⚠️
pkg/match/request.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   66.95%   66.27%   -0.69%     
==========================================
  Files          26       27       +1     
  Lines        1153     1269     +116     
==========================================
+ Hits          772      841      +69     
- Misses        330      369      +39     
- Partials       51       59       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdietrich-tc
Copy link
Contributor Author

I added the missing documentation for env.VARIABLE replacement variable support
(it also trigger a rerun of the CI which failed last time due to a rate limit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants