Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the router allow url that contains uri #138

Merged
merged 1 commit into from
Feb 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions config/urn.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
request:
method: GET
path: /api/v1/notes/urn:organization:notebook:eu:note:123
response:
statusCode: 200
headers:
Content-Type:
- "application/json"
body: "It works"
1 change: 0 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ module github.com/jmartin82/mmock/v3
go 1.14

require (
github.com/azer/url-router v0.0.0-20140924232216-1a0aa252538c
github.com/basgys/goxml2json v1.1.0
github.com/bitly/go-simplejson v0.5.0 // indirect
github.com/bmizerany/assert v0.0.0-20160611221934-b7ed37b82869 // indirect
Expand Down
2 changes: 0 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
github.com/Masterminds/glide v0.13.2/go.mod h1:STyF5vcenH/rUqTEv+/hBXlSTo7KYwg2oc2f4tzPWic=
github.com/Masterminds/semver v1.4.2/go.mod h1:MB6lktGJrhw8PrUyiEoblNEGEQ+RzHPF078ddwwvV3Y=
github.com/Masterminds/vcs v1.13.0/go.mod h1:N09YCmOQr6RLxC6UNHzuVwAdodYbbnycGHSmwVJjcKA=
github.com/azer/url-router v0.0.0-20140924232216-1a0aa252538c h1:vpYPra7G75NhuxN28VqQhTepM8a6c201AsJWdRaINqY=
github.com/azer/url-router v0.0.0-20140924232216-1a0aa252538c/go.mod h1:YT0FE3RD8ecPJBNkCdpeEAdZXPZgD2CqcRtpwuzjt9M=
github.com/basgys/goxml2json v1.1.0 h1:4ln5i4rseYfXNd86lGEB+Vi652IsIXIvggKM/BhUKVw=
github.com/basgys/goxml2json v1.1.0/go.mod h1:wH7a5Np/Q4QoECFIU8zTQlZwZkrilY0itPfecMw41Dw=
github.com/bitly/go-simplejson v0.5.0 h1:6IH+V8/tVMab511d5bn4M7EwGXZf9Hj6i2xSwkNEM+Y=
Expand Down
9 changes: 4 additions & 5 deletions pkg/match/request.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ import (

"github.com/jmartin82/mmock/v3/pkg/match/payload"
"github.com/jmartin82/mmock/v3/pkg/mock"

urlmatcher "github.com/azer/url-router"
"github.com/jmartin82/mmock/v3/pkg/route"

"github.com/ryanuber/go-glob"
)
Expand Down Expand Up @@ -132,14 +131,14 @@ func (mm Request) matchScenarioState(scenario *mock.Scenario) bool {
return false
}

//Matcher checks if the received request matches with some specific mock request config.
// Matcher checks if the received request matches with some specific mock request config.
type Matcher interface {
Match(req *mock.Request, mock *mock.Definition, scenarioAware bool) (bool, error)
}

func (mm Request) Match(req *mock.Request, mock *mock.Definition, scenarioAware bool) (bool, error) {

routes := urlmatcher.New(mock.Request.Path)
route := route.NewRoute(mock.Request.Path)

if !mm.matchOnEqualsOrIfEmptyOrGlob(req.Host, mock.Request.Host) {
return false, fmt.Errorf("Host not match. Actual: %s, Expected: %s", req.Host, mock.Request.Host)
Expand All @@ -153,7 +152,7 @@ func (mm Request) Match(req *mock.Request, mock *mock.Definition, scenarioAware
return false, fmt.Errorf("Fragment not match. Actual: %s, Expected: %s", req.Fragment, mock.Request.Fragment)
}

if !glob.Glob(mock.Request.Path, req.Path) && routes.Match(req.Path) == nil {
if !glob.Glob(mock.Request.Path, req.Path) && route.Match(req.Path) == nil {
return false, fmt.Errorf("Path not match. Actual: %s, Expected: %s", req.Path, mock.Request.Path)
}

Expand Down
65 changes: 65 additions & 0 deletions pkg/route/route.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
package route

import (
"fmt"
"regexp"
"strings"
)

type Route struct {
Keys []string
Regex *regexp.Regexp
Pattern string
}

type Match struct {
Params Params
Pattern string
}

type Params map[string]string

func (route *Route) Params(url string) Params {
match := route.Regex.FindAllStringSubmatch(url, -1)[0][1:]
result := make(Params)

for i := range match {
if len(route.Keys) <= i {
break
}

result[route.Keys[i]] = match[i]
}

return result
}
func (route *Route) Match(url string) *Match {
if route.Regex == nil || !route.Regex.MatchString(url) {
return nil
}
return &Match{route.Params(url), route.Pattern}
}

func NewRoute(pattern string) *Route {
regex, keys := pathToRegex(pattern)
return &Route{keys, regex, pattern}
}

func pathToRegex(path string) (*regexp.Regexp, []string) {
pattern, _ := regexp.Compile("\\/:([A-Za-z0-9]+)")
matches := pattern.FindAllStringSubmatch(path, -1)
keys := []string{}

for i := range matches {
keys = append(keys, matches[i][1])
}

str := fmt.Sprintf("^%s\\/?$", strings.Replace(path, "/", "\\/", -1))

str = pattern.ReplaceAllString(str, "/([^\\/]+)")
str = strings.Replace(str, ".", "\\.", -1)

regex, _ := regexp.Compile(str)

return regex, keys
}
45 changes: 45 additions & 0 deletions pkg/route/route_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
package route

import (
"fmt"
"testing"
)

func TestMatching(t *testing.T) {

route := NewRoute("/user/:name")
equal(t, route.Match("/user/azer").Pattern, "/user/:name")

route = NewRoute("/fruits/:fruit")
equal(t, route.Match("/fruits/watermelon").Pattern, "/fruits/:fruit")

route = NewRoute("/fruits/:fruit/:page")
equal(t, route.Match("/fruits/cherry/452").Pattern, "/fruits/:fruit/:page")

route = NewRoute("/api/urn:note:123")
equal(t, route.Match("/api/urn:note:123").Pattern, "/api/urn:note:123")

route = NewRoute("/api/:userid.json")
equal(t, route.Match("/api/99.json").Pattern, "/api/:userid.json")

route = NewRoute("/")
equal(t, route.Match("/").Pattern, "/")
}

func TestParams(t *testing.T) {
route := NewRoute("/user/:name")
equal(t, route.Match("/user/azer").Params["name"], "azer")

route = NewRoute("/fruits/:fruit")
equal(t, route.Match("/fruits/watermelon").Params["fruit"], "watermelon")

route = NewRoute("/fruits/:fruit/:page")
equal(t, route.Match("/fruits/cherry/452").Params["fruit"], "cherry")
equal(t, route.Match("/fruits/cherry/452").Params["page"], "452")
}

func equal(t *testing.T, a string, b string) {
if a != b {
t.Error(fmt.Sprintf("%s and %s aren't equal", a, b))
}
}
6 changes: 3 additions & 3 deletions pkg/vars/request.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import (
"strings"

"github.com/jmartin82/mmock/v3/pkg/mock"
"github.com/jmartin82/mmock/v3/pkg/route"

urlmatcher "github.com/azer/url-router"
xj "github.com/basgys/goxml2json"
"github.com/tidwall/gjson"
)
Expand Down Expand Up @@ -115,8 +115,8 @@ func (rp Request) getUrl() (string, bool) {

func (rp Request) getPathParam(name string) (string, bool) {

routes := urlmatcher.New(rp.Mock.Request.Path)
mparm := routes.Match(rp.Request.Path)
route := route.NewRoute(rp.Mock.Request.Path)
mparm := route.Match(rp.Request.Path)

value, f := mparm.Params[name]
if !f {
Expand Down