This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
Refactor 'evented data' so that it is the saga that is evented, rather than the data. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r than the data. This is in preparation for #10, which requires separation of the event handling and the data instance.
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=======================================
Coverage 45.71% 45.71%
=======================================
Files 38 38
Lines 1387 1387
=======================================
Hits 634 634
Misses 743 743
Partials 10 10Continue to review full report at Codecov.
|
jmalloc
commented
May 26, 2018
| @@ -114,3 +100,19 @@ func (aggregateRoot) HandleMessage( | |||
|
|
|||
| return | |||
| } | |||
|
|
|||
| // ApplyEvent updates the data to reflect the fact that ev has occurred. | |||
| func (aggregateRoot) ApplyEvent(d saga.Data, env ax.Envelope) { | |||
There was a problem hiding this comment.
Note that this method is now on the aggregateRoot (the saga.Saga implementation), not the saga data itself.
|
@koden-km Added you to this one for interest sake, but I'll merge away so I can make use of this elsewhere. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for #10, which requires separation of the event handling and the data instance.