Update pexpect to 4.4.0 #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
=======================================
Coverage 51.13% 51.13%
=======================================
Files 89 89
Lines 5004 5004
=======================================
Hits 2559 2559
Misses 2445 2445Continue to review full report at Codecov.
|
2 similar comments
|
Closing this in favor of #26 |
jluebbe
pushed a commit
that referenced
this pull request
Mar 21, 2024
The docker docs contain [1] these COPY forms: COPY [--chown=<user>:<group>] [--chmod=<perms>] <src>... <dest> COPY [--chown=<user>:<group>] [--chmod=<perms>] ["<src>",... "<dest>"] Arguments within [ ] are optional. The square brackets are not meant to be part of the actual instruction. The docker docs [1] mention that "[e]ach <src> may contain wildcards and matching will be done using Go’s filepath.Match rules". Go’s filepath.Match [2] interprets terms in square brackets as a character class. "[--chown=root:root]" must have been interpreted as a valid character class until recently. A couple of days ago, building the "dut" service started failing: Building dut #0 building with "default" instance using docker driver #1 [internal] load build definition from Dockerfile #1 transferring dockerfile: 924B done #1 DONE 0.0s #2 [internal] load .dockerignore #2 transferring context: 2B done #2 DONE 0.0s #3 [internal] load metadata for docker.io/library/debian:bookworm-slim #3 DONE 0.1s #4 [1/4] FROM docker.io/library/debian:bookworm-slim@sha256:89468107e4c2b9fdea2f15fc582bf92c25aa4296a661ca0202f7ea2f4fc3f48c #4 CACHED #5 [internal] load build context #5 transferring context: 56B done #5 ERROR: error from sender: invalid includepatterns: []: syntax error in pattern Fix this by dropping the accidental square brackets around the --chown option. [1] https://docs.docker.com/engine/reference/builder/#copy [2] https://pkg.go.dev/path/filepath#Match Signed-off-by: Bastian Krause <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a new version of pexpect available.
You are currently using 4.3.1. I have updated it to 4.4.0
These links might come in handy: PyPI | Changelog | Docs
Changelog
Got merge conflicts? Close this PR and delete the branch. I'll create a new PR for you.
Happy merging! 🤖