Fix dbschema mismatch #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well spotted @Peterburnett and thanks for the fix @tuanngocnguyen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Juan,
I have came across some mismatch in the DB schema, would you please have a loo:
'global' column
It has no default value in install.xml: https://github.com/jleyva/moodle-block_configurablereports/blob/MOODLE_36_STABLE/db/install.xml#L21
The default value is '0' in upgrade.php: https://github.com/jleyva/moodle-block_configurablereports/blob/MOODLE_36_STABLE/db/upgrade.php#L48
lastexecutiontime"
It has no default value in install.xml: https://github.com/jleyva/moodle-block_configurablereports/blob/MOODLE_36_STABLE/db/install.xml#L22
The default value is '0' in upgrade.php: https://github.com/jleyva/moodle-block_configurablereports/blob/MOODLE_36_STABLE/db/upgrade.php#L53
'cron':
It is NOT NULL in install.xml: https://github.com/jleyva/moodle-block_configurablereports/blob/MOODLE_36_STABLE/db/install.xml#L23
NULL is allowed in upgrade.php: https://github.com/jleyva/moodle-block_configurablereports/blob/MOODLE_36_STABLE/db/upgrade.php#L58
Thanks