forked from kubeflow/kfctl
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add the ability to create CloudEndpoint resources using kfctl.
* This is GCP specific code that allows CloudEndpoints to be created using the CloudEndpoint controller. A Cloud endpoint is a KRM style resource so we can kust have `kfctl apply -f {path}` invoke the appropriate logic. * For GCP this addresses GoogleCloudPlatform/kubeflow-distribution#36; specifically when deploying private GKE the CloudEndpoints controller won't be able to contact the servicemanagement API. This provides a work around by running it locally. * This pattern seems extensible; i.e. other platforms could link in code to handle CR's specific to their platforms. This could basically be an alternative to plugins. * I added a context flag to control the kubecontext that apply applies to. Unfortunately, it doesn't look like there is an easy way to use that in the context of applying KFDef. It looks like the current logic assumes the cluster will be added to the KFDef metadata and then look up that cluster in .kubeconfig. * Modifying that logic to support the context flag seemed riskier then simply adding a comment to the flag. * Added some warnings that KFUpgrade is deprecated since per kubeflow#304 we want to follow the off shelf workflow.
- Loading branch information
Jeremy Lewi
committed
Jun 5, 2020
1 parent
4c1060b
commit 389f40c
Showing
4 changed files
with
170 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.