-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to git dependencies in private/ssh repositories #128
Conversation
ecb1e25
to
772a50b
Compare
If you've been running it for a year without noticing any performance issues, I think we're good to go with |
this allows us to do the same secure hash checking, as fetchgit
to avoid patching shebangs, which would mess with fixed-output
I think the One issue that I've found with both bultins is, that they are already downloaded during eval (i.e. There is a related issue in nix NixOS/nix#9077 (comment), so maybe we'll benefit from a resolution eventually ... Your call now. As far as I'm concerned, P.S. if you are concerned about big repos and that nix issue, then I can also rework this, so that a dependency can take e.g. |
now that this test uses pkgs.fetchgit again This reverts commit 690f5c9.
eh .. I think that test is non deterministic. the same commit on my machine r/n: ± nix develop --command kaocha
integration: 100% [==================================================] 15/15
unit: 100% [==================================================] 13/13
28 tests, 62 assertions, 0 failures.
± git show HEAD
commit 2f75dde9069a4154d6ecd95abb4197835b54cab4 (HEAD -> builtin-fetchgit, origin/builtin-fetchgit) |
Thanks a lot, I'm happy with the current version, merging it as it is :) |
fix #70
implements Option 2:
Only builtins.fetchGit
I've been running with this option since a year ago, to access my private git repositories. I feel that this is the best option:
Despite using it only with ssh urls myself, I feel like it's also a good bet for http urls, since those may also have credential integration, that
builtins.fetchGit
can access.