Skip to content

Commit

Permalink
Merge pull request javaparser#4480 from johannescoetzee/johannes/sepa…
Browse files Browse the repository at this point in the history
…rate-style-workflows

Move formatting workflows into separate file
  • Loading branch information
jlerbsc authored Jun 24, 2024
2 parents f75a50c + f4fe6f3 commit 1df12b1
Show file tree
Hide file tree
Showing 2 changed files with 63 additions and 37 deletions.
63 changes: 63 additions & 0 deletions .github/workflows/formatting_check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
name: Check codegen and formatting

#on: [push, pull_request]
#on: [pull_request]
on:
# Trigger the workflow on push to master (ignoring .md only changes)
push:
branches:
- master
paths-ignore:
- '**.md'

# Trigger the workflow on any pull_request (ignoring .md only changes)
pull_request:
paths-ignore:
- '**.md'

# Enable manual triggering (important for contributors to enable a check on their fork)
workflow_dispatch:

# If a build is running in the current branch, and the branch is updated, we cancel the previous build and start
# a new one with the updated changes.
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
# Run checkstyle validations for pipeline
checkstyle_check:
name: Validate checkstyle
runs-on: ubuntu-latest
steps:
- name: Checkout latest code
uses: actions/[email protected]
with:
fetch-depth: "0"
- name: Set up JDK 11
uses: actions/setup-java@v4
with:
java-version: '11'
distribution: 'zulu'
- name: Validate Project Checkstyle
run: ./mvnw -B checkstyle:check

spotless_check:
name: Spotless check
runs-on: ubuntu-latest
steps:
- name: Checkout latest code
uses: actions/[email protected]
with:
fetch-depth: "0"
- name: Set up JDK 11
uses: actions/setup-java@v4
with:
java-version: '11'
distribution: 'zulu'
- name: Generate code and format
run: |
./run_core_metamodel_generator.sh
# ./run_core_generators.sh automatically runs ./mvnw spotless:apply
./run_core_generators.sh
git diff --exit-code
37 changes: 0 additions & 37 deletions .github/workflows/maven_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,40 +114,3 @@ jobs:
verbose: false # optional (default = false):
flags: javaparser-symbol-solver,AlsoSlowTests,${{ matrix.os }},jdk-${{ matrix.jdk }}
env_vars: OS,JDK

# Run checkstyle validations for pipeline
checkstyle_check:
name: Validate checkstyle
runs-on: ubuntu-latest
steps:
- name: Checkout latest code
uses: actions/[email protected]
with:
fetch-depth: "0"
- name: Set up JDK 11
uses: actions/setup-java@v4
with:
java-version: '11'
distribution: 'zulu'
- name: Validate Project Checkstyle
run: ./mvnw -B checkstyle:check

spotless_check:
name: Validate code generation and formatting
runs-on: ubuntu-latest
steps:
- name: Checkout latest code
uses: actions/[email protected]
with:
fetch-depth: "0"
- name: Set up JDK 11
uses: actions/setup-java@v4
with:
java-version: '11'
distribution: 'zulu'
- name: Generate code and format
run: |
./run_core_metamodel_generator.sh
# ./run_core_generators.sh automatically runs ./mvnw spotless:apply
./run_core_generators.sh
git diff --exit-code

0 comments on commit 1df12b1

Please sign in to comment.