files: don't run setfiles with -i

We shouldn't need to run `setfiles` with `-i`, which causes `setfiles`
to ignore files that do not exist. All the files which we pass to
`setfiles` should exist, and it should be a hard error if `setfiles`
fails to find and relabel the file we wrote.

This dates from coreos#632, where we
added `/var/home` and `/var/roothome` for OSTree-based systems. We
actually don't need to special-case OSTree systems at all anymore.

The `/var/home` and `/var/roothome` directories themselves are now
handled by `ignition-ostree-populate-var.service`. All we need to take
care of here is to relabel the homedir files we created for each user.
This is distro-agnostic.

internal/exec/stages/files/passwd.go

@@ -66,12 +66,23 @@ func (s *stage) createPasswd(config types.Config) error {
 		}
 
 		s.relabel(deglobbed...)
-		s.relabel(
-			"/etc/.pwd.lock",
-			// for OSTree-based systems
-			"/var/home",
-			"/var/roothome",
-		)
+		s.relabel("/etc/.pwd.lock")
+		for _, user := range config.Passwd.Users {
+			if user.NoCreateHome != nil && *user.NoCreateHome == true {
+				continue
+			}
+			if user.Name == "root" {
+				rootdir_deglobbed, err := s.expandGlobList("/root/*")
+				if err != nil {
+					return err
+				}
+				s.relabel(rootdir_deglobbed...)
+			} else if user.HomeDir != nil && *user.HomeDir != "" {
+				s.relabel(filepath.Join(*user.HomeDir))
+			} else {
+				s.relabel(filepath.Join("/home", user.Name))
+			}
+		}
 	}
 
 	return nil

internal/exec/util/selinux.go

@@ -77,7 +77,7 @@ func (ut Util) RelabelFiles(patterns []string) error {
 		return err
 	}
 
-	cmd := exec.Command(distro.SetfilesCmd(), "-vFi0", "-r", ut.DestDir, file_contexts, "-f", "-")
+	cmd := exec.Command(distro.SetfilesCmd(), "-vF0", "-r", ut.DestDir, file_contexts, "-f", "-")
 	cmd.Stdin = strings.NewReader(strings.Join(patterns, "\000") + "\000")
 	if _, err := ut.Logger.LogCmd(cmd, "relabeling %d patterns", len(patterns)); err != nil {
 		return err